Commit 6d9c7b27 authored by Chiara Meiohas's avatar Chiara Meiohas Committed by Leon Romanovsky
Browse files

RDMA/mlx5: Call dev_put() after the blocking notifier 



Move dev_put() call to occur directly after the blocking
notifier, instead of within the event handler.

Fixes: 8d159eb2 ("RDMA/mlx5: Use IB set_netdev and get_netdev functions")
Signed-off-by: default avatarChiara Meiohas <cmeiohas@nvidia.com>
Link: https://patch.msgid.link/342ff94b3dcbb07da1c7dab862a73933d604b717.1730381292.git.leon@kernel.org


Signed-off-by: default avatarLeon Romanovsky <leon@kernel.org>
parent eb3d354e

drivers/infiniband/hw/mlx5/main.c

+0 −1
Original line number Diff line number Diff line
@@ -3242,7 +3242,6 @@ static int lag_event(struct notifier_block *nb, unsigned long event, void *data) 
			}

			err = ib_device_set_netdev(&dev->ib_dev, ndev,

						   portnum + 1);

			dev_put(ndev);

			if (err)

				return err;

			/* Rescan gids after new netdev assignment */

drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c

+1 −0
Original line number Diff line number Diff line
@@ -516,6 +516,7 @@ void mlx5_modify_lag(struct mlx5_lag *ldev, 
		blocking_notifier_call_chain(&dev0->priv.lag_nh,

					     MLX5_DRIVER_EVENT_ACTIVE_BACKUP_LAG_CHANGE_LOWERSTATE,

					     ndev);

		dev_put(ndev);

	}

}