Commit 6dba9b72 authored by Biju Das's avatar Biju Das Committed by Geert Uytterhoeven
Browse files

pinctrl: renesas: rzg2l: Fix incorrect PUPD register offset for high pins during suspend/resume 



When saving/restoring pull-up/down register state during suspend/resume,
the second PUPD register access was incorrectly using the same base offset
as the first, effectively reading/writing the same register twice instead
of the adjacent one.

Add the correct + 4 byte offset to the second RZG2L_PCTRL_REG_ACCESS32
call so that pupd[1][port] is properly saved and restored from the next
32-bit register in the PUPD register pair, covering pins 4–7 of ports
with 4 or more pins.

Fixes: b2bd65fb ("pinctrl: renesas: rzg2l: Add suspend/resume support for pull up/down")
Signed-off-by: default avatarBiju Das <biju.das.jz@bp.renesas.com>
Reviewed-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
Link: https://patch.msgid.link/20260328090548.84124-1-biju.das.jz@bp.renesas.com


Signed-off-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
parent 254f4963

drivers/pinctrl/renesas/pinctrl-rzg2l.c

+1 −1
Original line number Diff line number Diff line
@@ -3049,7 +3049,7 @@ static void rzg2l_pinctrl_pm_setup_regs(struct rzg2l_pinctrl *pctrl, bool suspen 
			RZG2L_PCTRL_REG_ACCESS32(suspend, pctrl->base + PUPD(off),

						 cache->pupd[0][port]);

			if (pincnt >= 4) {

				RZG2L_PCTRL_REG_ACCESS32(suspend, pctrl->base + PUPD(off),

				RZG2L_PCTRL_REG_ACCESS32(suspend, pctrl->base + PUPD(off) + 4,

							 cache->pupd[1][port]);

			}

		}