Commit 6dcf9d00 authored by Guangshuo Li's avatar Guangshuo Li Committed by Rafael J. Wysocki
Browse files

cpufreq: governor: fix double free in cpufreq_dbs_governor_init() error path 



When kobject_init_and_add() fails, cpufreq_dbs_governor_init() calls
kobject_put(&dbs_data->attr_set.kobj).

The kobject release callback cpufreq_dbs_data_release() calls
gov->exit(dbs_data) and kfree(dbs_data), but the current error path
then calls gov->exit(dbs_data) and kfree(dbs_data) again, causing a
double free.

Keep the direct kfree(dbs_data) for the gov->init() failure path, but
after kobject_init_and_add() has been called, let kobject_put() handle
the cleanup through cpufreq_dbs_data_release().

Fixes: 4ebe36c9 ("cpufreq: Fix kobject memleak")
Signed-off-by: default avatarGuangshuo Li <lgs201920130244@gmail.com>
Reviewed-by: default avatarZhongqiu Han <zhongqiu.han@oss.qualcomm.com>
Acked-by: default avatarViresh Kumar <viresh.kumar@linaro.org>
Cc: All applicable <stable@vger.kernel.org>
Link: https://patch.msgid.link/20260401024535.1395801-1-lgs201920130244@gmail.com


Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent 7aaa8047

drivers/cpufreq/cpufreq_governor.c

+3 −3
Original line number Diff line number Diff line
@@ -468,13 +468,13 @@ int cpufreq_dbs_governor_init(struct cpufreq_policy *policy) 
	/* Failure, so roll back. */

	pr_err("initialization failed (dbs_data kobject init error %d)\n", ret);



	kobject_put(&dbs_data->attr_set.kobj);



	policy->governor_data = NULL;



	if (!have_governor_per_policy())

		gov->gdbs_data = NULL;

	gov->exit(dbs_data);



	kobject_put(&dbs_data->attr_set.kobj);

	goto free_policy_dbs_info;



free_dbs_data:

	kfree(dbs_data);