Commit 6ddb173f authored by Navaneeth K's avatar Navaneeth K Committed by Greg Kroah-Hartman
Browse files

staging: rtl8723bs: use standard offsetof in cfg80211 operations 



Replace usage of the custom FIELD_OFFSET macro with the standard
offsetof() macro in ioctl_cfg80211.c. This improves code readability
and uses the kernel's standard mechanism.

Also include <linux/stddef.h> in basic_types.h to ensure offsetof()
is available for this and future conversions.

Signed-off-by: default avatarNavaneeth K <knavaneeth786@gmail.com>
Reviewed-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Link: https://patch.msgid.link/20251125112059.16913-3-knavaneeth786@gmail.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent e09748f8

drivers/staging/rtl8723bs/include/basic_types.h

+1 −0
Original line number Diff line number Diff line
@@ -12,6 +12,7 @@ 
#define FAIL	(-1)



#include <linux/types.h>

#include <linux/stddef.h>



#define FIELD_OFFSET(s, field)	((__kernel_ssize_t)&((s *)(0))->field)

drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c

+2 −1
Original line number Diff line number Diff line
@@ -1712,7 +1712,8 @@ static int cfg80211_rtw_connect(struct wiphy *wiphy, struct net_device *ndev, 


		if (wep_key_len > 0) {

			wep_key_len = wep_key_len <= 5 ? 5 : 13;

			wep_total_len = wep_key_len + FIELD_OFFSET(struct ndis_802_11_wep, key_material);

			wep_total_len = wep_key_len +

				offsetof(struct ndis_802_11_wep, key_material);

			pwep = rtw_malloc(wep_total_len);

			if (!pwep) {

				ret = -ENOMEM;