Commit 6e1d75f7 authored by NeilBrown's avatar NeilBrown Committed by Chuck Lever
Browse files

sunrpc/svc: use store_release_wake_up() 



svc_thread_init_status() contains an open-coded
store_release_wake_up().  It is cleaner to use that function directly
rather than needing to remember the barrier.

Signed-off-by: default avatarNeilBrown <neilb@suse.de>
Reviewed-by: default avatarJeff Layton <jlayton@kernel.org>
Signed-off-by: default avatarChuck Lever <chuck.lever@oracle.com>
parent 935fee5d

include/linux/sunrpc/svc.h

+1 −6
Original line number Diff line number Diff line
@@ -327,12 +327,7 @@ static inline bool svc_thread_should_stop(struct svc_rqst *rqstp) 
 */

static inline void svc_thread_init_status(struct svc_rqst *rqstp, int err)

{

	rqstp->rq_err = err;

	/* memory barrier ensures assignment to error above is visible before

	 * waitqueue_active() test below completes.

	 */

	smp_mb();

	wake_up_var(&rqstp->rq_err);

	store_release_wake_up(&rqstp->rq_err, err);

	if (err)

		kthread_exit(1);

}