Commit 6e3f07f9 authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Stephen Boyd
Browse files

clk: fractional-divider: Move mask calculations out of lock 



There is no need to calculate masks under the lock taken.
Move them out of it.

Signed-off-by: default avatarAndy Shevchenko <andy.shevchenko@gmail.com>
Link: https://lore.kernel.org/r/20240303121410.240761-1-andy.shevchenko@gmail.com


Reviewed-by: default avatarChen-Yu Tsai <wenst@chromium.org>
Reviewed-by: default avatarHeiko Stuebner <heiko@sntech.de>
Signed-off-by: default avatarStephen Boyd <sboyd@kernel.org>
parent 9b6c057b

drivers/clk/clk-fractional-divider.c

+3 −3
Original line number Diff line number Diff line
@@ -195,14 +195,14 @@ static int clk_fd_set_rate(struct clk_hw *hw, unsigned long rate, 
		n--;

	}



	mmask = GENMASK(fd->mwidth - 1, 0) << fd->mshift;

	nmask = GENMASK(fd->nwidth - 1, 0) << fd->nshift;



	if (fd->lock)

		spin_lock_irqsave(fd->lock, flags);

	else

		__acquire(fd->lock);



	mmask = GENMASK(fd->mwidth - 1, 0) << fd->mshift;

	nmask = GENMASK(fd->nwidth - 1, 0) << fd->nshift;



	val = clk_fd_readl(fd);

	val &= ~(mmask | nmask);

	val |= (m << fd->mshift) | (n << fd->nshift);