Commit 6e3f4514 authored by Tvrtko Ursulin's avatar Tvrtko Ursulin Committed by Tvrtko Ursulin
Browse files

drm/ttm: Fix ttm_pool_beneficial_order() return type 



Fix a nasty copy and paste bug, where the incorrect boolean return type of
the ttm_pool_beneficial_order() helper had a consequence of avoiding
direct reclaim too eagerly for drivers which use this feature (currently
amdgpu).

Signed-off-by: default avatarTvrtko Ursulin <tvrtko.ursulin@igalia.com>
Fixes: 7e9c548d ("drm/ttm: Allow drivers to specify maximum beneficial TTM pool size")
Cc: Christian König <christian.koenig@amd.com>
Cc: Thadeu Lima de Souza Cascardo <cascardo@igalia.com>
Cc: dri-devel@lists.freedesktop.org
Cc: <stable@vger.kernel.org> # v6.19+
Reviewed-by: default avatarChristian König <christian.koenig@amd.com>
Signed-off-by: default avatarTvrtko Ursulin <tursulin@ursulin.net>
Link: https://lore.kernel.org/r/20260227124901.3177-1-tvrtko.ursulin@igalia.com
parent 36d9579f

drivers/gpu/drm/ttm/ttm_pool_internal.h

+1 −1
Original line number Diff line number Diff line
@@ -17,7 +17,7 @@ static inline bool ttm_pool_uses_dma32(struct ttm_pool *pool) 
	return pool->alloc_flags & TTM_ALLOCATION_POOL_USE_DMA32;

}



static inline bool ttm_pool_beneficial_order(struct ttm_pool *pool)

static inline unsigned int ttm_pool_beneficial_order(struct ttm_pool *pool)

{

	return pool->alloc_flags & 0xff;

}