Commit 6e55caaf authored by Christophe JAILLET's avatar Christophe JAILLET Committed by Andi Shyti
Browse files

i2c: ali15x3: Fix an error handling path in ali15x3_probe() 



If i2c_add_adapter() fails, the request_region() call in ali15x3_setup()
must be undone by a corresponding release_region() call, as done in the
remove function.

Fixes: 1da177e4 ("Linux-2.6.12-rc2")
Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: default avatarAndi Shyti <andi.shyti@kernel.org>
Link: https://lore.kernel.org/r/9b2090cbcc02659f425188ea05f2e02745c4e67b.1741031878.git.christophe.jaillet@wanadoo.fr
parent 9b5463f3

drivers/i2c/busses/i2c-ali15x3.c

+11 −1
Original line number Diff line number Diff line
@@ -472,6 +472,8 @@ MODULE_DEVICE_TABLE (pci, ali15x3_ids); 


static int ali15x3_probe(struct pci_dev *dev, const struct pci_device_id *id)

{

	int ret;



	if (ali15x3_setup(dev)) {

		dev_err(&dev->dev,

			"ALI15X3 not detected, module not inserted.\n");
@@ -483,7 +485,15 @@ static int ali15x3_probe(struct pci_dev *dev, const struct pci_device_id *id) 


	snprintf(ali15x3_adapter.name, sizeof(ali15x3_adapter.name),

		"SMBus ALI15X3 adapter at %04x", ali15x3_smba);

	return i2c_add_adapter(&ali15x3_adapter);

	ret = i2c_add_adapter(&ali15x3_adapter);

	if (ret)

		goto release_region;



	return 0;



release_region:

	release_region(ali15x3_smba, ALI15X3_SMB_IOSIZE);

	return ret;

}



static void ali15x3_remove(struct pci_dev *dev)