Commit 6e5cbf46 authored by Rafael J. Wysocki's avatar Rafael J. Wysocki
Browse files

ACPI: PAD: Rearrange notify handler installation and removal 



Use acpi_dev_install_notify_handler() and acpi_dev_remove_notify_handler()
for installing and removing the ACPI notify handler, respectively, which
allows acpi_pad_notify() and acpi_pad_remove() to be simplified quite a
bit.

No intentional functional impact.

Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
Link: https://patch.msgid.link/2011993.taCxCBeP46@rafael.j.wysocki
parent 6a0c7d38

drivers/acpi/acpi_pad.c

+5 −14
Original line number Diff line number Diff line
@@ -407,8 +407,7 @@ static void acpi_pad_handle_notify(acpi_handle handle) 
	mutex_unlock(&isolated_cpus_lock);

}



static void acpi_pad_notify(acpi_handle handle, u32 event,

	void *data)

static void acpi_pad_notify(acpi_handle handle, u32 event, void *data)

{

	struct acpi_device *adev = data;
@@ -427,29 +426,21 @@ static void acpi_pad_notify(acpi_handle handle, u32 event, 
static int acpi_pad_probe(struct platform_device *pdev)

{

	struct acpi_device *adev = ACPI_COMPANION(&pdev->dev);

	acpi_status status;



	strscpy(acpi_device_name(adev), ACPI_PROCESSOR_AGGREGATOR_DEVICE_NAME);

	strscpy(acpi_device_class(adev), ACPI_PROCESSOR_AGGREGATOR_CLASS);



	status = acpi_install_notify_handler(adev->handle,

		ACPI_DEVICE_NOTIFY, acpi_pad_notify, adev);



	if (ACPI_FAILURE(status))

		return -ENODEV;



	return 0;

	return acpi_dev_install_notify_handler(adev, ACPI_DEVICE_NOTIFY,

					       acpi_pad_notify, adev);

}



static void acpi_pad_remove(struct platform_device *pdev)

{

	struct acpi_device *adev = ACPI_COMPANION(&pdev->dev);



	mutex_lock(&isolated_cpus_lock);

	acpi_pad_idle_cpus(0);

	mutex_unlock(&isolated_cpus_lock);



	acpi_remove_notify_handler(adev->handle,

	acpi_dev_remove_notify_handler(ACPI_COMPANION(&pdev->dev),

				       ACPI_DEVICE_NOTIFY, acpi_pad_notify);

}