Commit 6e7daa3d authored by Olga Kornievskaia's avatar Olga Kornievskaia Committed by Trond Myklebust
Browse files

NFSv4.2: fix CLONE/COPY attrs in presence of delegated attributes 



xfstest generic/407 is failing in 2 ways. It detects that after
doing a clone the client does not update it's mtime and it's ctime.
CLONE always sends a GETATTR operation and then calls
nfs_post_op_update_inode() based on the returned attributes.
Because of the delegated attributes the client ignores updating
the mtime. Then also, when delegated attributes are present, for
the change_attr the server replies with the same values as what
the client cached before and thus the generic/407 would flag that.
Instead, make sure we invalidate the blocks attr.

By adding updating delegated attributes in nfs42_copy_dest_done()
both COPY and CLONE would update mtime appropriately.

Fixes: e12912d9 ("NFSv4: Add support for delegated atime and mtime attributes")
Signed-off-by: default avatarOlga Kornievskaia <okorniev@redhat.com>
Signed-off-by: default avatarTrond Myklebust <trond.myklebust@hammerspace.com>
parent 5d3869a4

fs/nfs/nfs42proc.c

+1 −0
Original line number Diff line number Diff line
@@ -401,6 +401,7 @@ static void nfs42_copy_dest_done(struct file *file, loff_t pos, loff_t len, 
					     NFS_INO_INVALID_MTIME |

					     NFS_INO_INVALID_BLOCKS);

	spin_unlock(&inode->i_lock);

	nfs_update_delegated_mtime(inode);

}



static ssize_t _nfs42_proc_copy(struct file *src,