Commit 6e975297 authored by Pavel Begunkov's avatar Pavel Begunkov Committed by Jens Axboe
Browse files

io_uring: don't free never created regions 



io_free_region() tolerates empty regions but there is no reason to that
either. If the first io_create_region() in io_register_resize_rings()
fails, just return the error without attempting to clean it up.

Signed-off-by: default avatarPavel Begunkov <asml.silence@gmail.com>
Reviewed-by: default avatarGabriel Krisman Bertazi <krisman@suse.de>
Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 0c89dbbc

io_uring/register.c

+2 −3
Original line number Diff line number Diff line
@@ -432,10 +432,9 @@ static int io_register_resize_rings(struct io_ring_ctx *ctx, void __user *arg) 
		rd.flags |= IORING_MEM_REGION_TYPE_USER;

	}

	ret = io_create_region(ctx, &n.ring_region, &rd, IORING_OFF_CQ_RING);

	if (ret) {

		io_register_free_rings(ctx, &n);

	if (ret)

		return ret;

	}



	n.rings = io_region_get_ptr(&n.ring_region);



	/*