Commit 6ea68a8d authored by Mike Christie's avatar Mike Christie Committed by Martin K. Petersen
Browse files

scsi: sd: Fix return code handling in sd_spinup_disk() 



As found by smatch-ci, scsi_execute_cmd() can return negative or positve
values so we should use a int instead of unsigned int.

Fixes: b4d0c33a ("scsi: sd: Fix sshdr use in sd_spinup_disk")
Reported-by: default avatarDan Carpenter <error27@gmail.com>
Closes: https://lore.kernel.org/linux-scsi/agFbI7E6JQwd3wGW@stanley.mountain/T/#u


Signed-off-by: default avatarMike Christie <michael.christie@oracle.com>
Reviewed-by: default avatarBart Van Assche <bvanassche@acm.org>
Link: https://patch.msgid.link/20260511175317.114007-1-michael.christie@oracle.com


Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 98f69975

drivers/scsi/sd.c

+1 −2
Original line number Diff line number Diff line
@@ -2476,8 +2476,7 @@ sd_spinup_disk(struct scsi_disk *sdkp) 
{

	static const u8 cmd[10] = { TEST_UNIT_READY };

	unsigned long spintime_expire = 0;

	int spintime, sense_valid = 0;

	unsigned int the_result;

	int the_result, spintime, sense_valid = 0;

	struct scsi_sense_hdr sshdr;

	struct scsi_failure failure_defs[] = {

		/* Do not retry Medium Not Present */