Commit 6ecfe7c2 authored by Maxime Ripard's avatar Maxime Ripard Committed by Dave Stevenson
Browse files

drm/vc4: hdmi: Warn if writing to an unknown HDMI register 



The VC4 HDMI driver has a bunch of accessors to read from a register.
The read accessor was warning when accessing an unknown register, but
the write one was just returning silently.

Let's make sure we warn also when writing to an unknown register.

Signed-off-by: default avatarMaxime Ripard <mripard@kernel.org>
Reviewed-by: default avatarMaxime Ripard <mripard@kernel.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20240621152055.4180873-9-dave.stevenson@raspberrypi.com


Signed-off-by: default avatarDave Stevenson <dave.stevenson@raspberrypi.com>
parent 59f8b2b7

drivers/gpu/drm/vc4/vc4_hdmi_regs.h

+4 −1
Original line number Diff line number Diff line
@@ -498,8 +498,11 @@ static inline void vc4_hdmi_write(struct vc4_hdmi *hdmi, 


	field = &variant->registers[reg];

	base = __vc4_hdmi_get_field_base(hdmi, field->reg);

	if (!base)

	if (!base) {

		dev_warn(&hdmi->pdev->dev,

			 "Unknown register ID %u\n", reg);

		return;

	}



	writel(value, base + field->offset);

}