Commit 6f1cacf4 authored by Philipp Stanner's avatar Philipp Stanner Committed by Danilo Krummrich
Browse files

drm/nouveau: Improve variable name in nouveau_sched_init() 



nouveau_sched_init() uses the function drm_sched_init(). The latter
function has parameters called "hang_limit" and "timeout" in its API
documentation.

nouveau_sched_init(), however, defines a variable called
"job_hang_limit" which is passed to drm_sched_init()'s "timeout"
parameter. The actual "hang_limit" parameter is directly set to 0.

Rename "job_hang_limit" to "timeout".

Signed-off-by: default avatarPhilipp Stanner <pstanner@redhat.com>
Signed-off-by: default avatarDanilo Krummrich <dakr@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240712062618.8057-1-pstanner@redhat.com
parent 0daf44ea

drivers/gpu/drm/nouveau/nouveau_sched.c

+2 −2
Original line number Diff line number Diff line
@@ -404,7 +404,7 @@ nouveau_sched_init(struct nouveau_sched *sched, struct nouveau_drm *drm, 
{

	struct drm_gpu_scheduler *drm_sched = &sched->base;

	struct drm_sched_entity *entity = &sched->entity;

	long job_hang_limit = msecs_to_jiffies(NOUVEAU_SCHED_JOB_TIMEOUT_MS);

	const long timeout = msecs_to_jiffies(NOUVEAU_SCHED_JOB_TIMEOUT_MS);

	int ret;



	if (!wq) {
@@ -418,7 +418,7 @@ nouveau_sched_init(struct nouveau_sched *sched, struct nouveau_drm *drm, 


	ret = drm_sched_init(drm_sched, &nouveau_sched_ops, wq,

			     NOUVEAU_SCHED_PRIORITY_COUNT,

			     credit_limit, 0, job_hang_limit,

			     credit_limit, 0, timeout,

			     NULL, NULL, "nouveau_sched", drm->dev->dev);

	if (ret)

		goto fail_wq;