Commit 6f25e5de authored by Riyan Dhiman's avatar Riyan Dhiman Committed by Ulf Hansson
Browse files

mmc: core: Convert simple_stroul to kstroul 



simple_strtoul() is obsolete and lacks proper error handling, making it
unsafe for converting strings to unsigned long values. Replace it with
kstrtoul(), which provides robust error checking and better safety.

This change improves the reliability of the string-to-integer conversion
and aligns with current kernel coding standards. Error handling is added
to catch conversion failures, returning -EINVAL when input is invalid.

Issue reported by checkpatch:
- WARNING: simple_strtoul is obsolete, use kstrtoul instead

Signed-off-by: default avatarRiyan Dhiman <riyandhiman14@gmail.com>
Link: https://lore.kernel.org/r/20240901182244.45543-1-riyandhiman14@gmail.com


Signed-off-by: default avatarUlf Hansson <ulf.hansson@linaro.org>
parent d2253bfa

drivers/mmc/core/block.c

+3 −3
Original line number Diff line number Diff line
@@ -353,10 +353,10 @@ static ssize_t force_ro_store(struct device *dev, struct device_attribute *attr, 
			      const char *buf, size_t count)

{

	int ret;

	char *end;

	struct mmc_blk_data *md = mmc_blk_get(dev_to_disk(dev));

	unsigned long set = simple_strtoul(buf, &end, 0);

	if (end == buf) {

	unsigned long set;



	if (kstrtoul(buf, 0, &set)) {

		ret = -EINVAL;

		goto out;

	}