Unverified Commit 6f9026b5 authored by Cosmin Tanislav's avatar Cosmin Tanislav Committed by Mark Brown
Browse files

spi: rzv2h-rspi: set MUST_RX/MUST_TX 



In preparation for implementing DMA support, set MUST_RX and MUST_TX
flags on the controller so that we always receive non-NULL buffers.

The PIO mode already handles this manually by checking if rx_buf/tx_buf
are set on the transfer, and doing a dummy read/write if not.

DMA will not be able to implement this special handling, and although
the SPI controller advertises support for transmit-only or receive-only
transfers via SPCR's register TXMD bitfield, it does not seem to work.

Remove the special handling for PIO and let the SPI controller core
handle it.

Signed-off-by: default avatarCosmin Tanislav <cosmin-gabriel.tanislav.xa@renesas.com>
Link: https://patch.msgid.link/20251201134229.600817-7-cosmin-gabriel.tanislav.xa@renesas.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 28b590bd

drivers/spi/spi-rzv2h-rspi.c

+3 −8
Original line number Diff line number Diff line
@@ -113,11 +113,7 @@ struct rzv2h_rspi_priv { 
static inline void rzv2h_rspi_tx_##type(struct rzv2h_rspi_priv *rspi,	\

					const void *txbuf,		\

					unsigned int index) {		\

	type buf = 0;							\

									\

	if (txbuf)							\

		buf = ((type *)txbuf)[index];				\

									\

	type buf = ((type *)txbuf)[index];				\

	func(buf, rspi->base + RSPI_SPDR);				\

}
@@ -126,8 +122,6 @@ static inline void rzv2h_rspi_rx_##type(struct rzv2h_rspi_priv *rspi, \ 
					void *rxbuf,			\

					unsigned int index) {		\

	type buf = func(rspi->base + RSPI_SPDR);			\

									\

	if (rxbuf)							\

	((type *)rxbuf)[index] = buf;					\

}
@@ -596,6 +590,7 @@ static int rzv2h_rspi_probe(struct platform_device *pdev) 


	controller->mode_bits = SPI_CPHA | SPI_CPOL | SPI_CS_HIGH |

				SPI_LSB_FIRST | SPI_LOOP;

	controller->flags = SPI_CONTROLLER_MUST_RX | SPI_CONTROLLER_MUST_TX;

	controller->bits_per_word_mask = SPI_BPW_RANGE_MASK(4, 32);

	controller->prepare_message = rzv2h_rspi_prepare_message;

	controller->unprepare_message = rzv2h_rspi_unprepare_message;