Commit 6fcac87e authored by QiuXi's avatar QiuXi Committed by Linus Torvalds
Browse files

coredump: fix memleak in dump_vma_snapshot() 

dump_vma_snapshot() allocs memory for *vma_meta, when dump_vma_snapshot()
returns -EFAULT, the memory will be leaked, so we free it correctly.

Link: https://lkml.kernel.org/r/20210810020441.62806-1-qiuxi1@huawei.com


Fixes: a07279c9 ("binfmt_elf, binfmt_elf_fdpic: use a VMA list snapshot")
Signed-off-by: default avatarQiuXi <qiuxi1@huawei.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Jann Horn <jannh@google.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent dbd9d6f8

fs/coredump.c

+3 −1
Original line number Diff line number Diff line
@@ -1134,8 +1134,10 @@ int dump_vma_snapshot(struct coredump_params *cprm, int *vma_count, 


	mmap_write_unlock(mm);



	if (WARN_ON(i != *vma_count))

	if (WARN_ON(i != *vma_count)) {

		kvfree(*vma_meta);

		return -EFAULT;

	}



	*vma_data_size_ptr = vma_data_size;

	return 0;