Commit 6fd893a4 authored by Matthew Wilcox (Oracle)'s avatar Matthew Wilcox (Oracle) Committed by Andrew Morton
Browse files

mm: remove redundant test in validate_page_before_insert() 

The page_has_type() call would have included slab since commit
46df8e73 and now we don't even get that far because slab pages have a
zero refcount since commit 9aec2fb0.

Link: https://lkml.kernel.org/r/20250910142923.2465470-3-willy@infradead.org


Signed-off-by: default avatarMatthew Wilcox (Oracle) <willy@infradead.org>
Acked-by: default avatarDavid Hildenbrand <david@redhat.com>
Acked-by: default avatarVlastimil Babka <vbabka@suse.cz>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent 3a37469e

mm/memory.c

+1 −2
Original line number Diff line number Diff line
@@ -2266,8 +2266,7 @@ static int validate_page_before_insert(struct vm_area_struct *vma, 
			return -EINVAL;

		return 0;

	}

	if (folio_test_anon(folio) || folio_test_slab(folio) ||

	    page_has_type(page))

	if (folio_test_anon(folio) || page_has_type(page))

		return -EINVAL;

	flush_dcache_folio(folio);

	return 0;