Commit 6ff78df5 authored Nov 04, 2024 by Rob Herring (Arm) Committed by Greg Kroah-Hartman Nov 05, 2024

usb: Use (of|device)_property_present() for non-boolean properties



The use of (of|device)_property_read_bool() for non-boolean properties
is deprecated in favor of of_property_present() when testing for
property presence.

Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
Acked-by: Peter Chen <peter.chen@kernel.org>
Acked-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
Link: https://lore.kernel.org/r/20241104190820.277702-1-robh@kernel.org


Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent e9d593c6

drivers/usb/chipidea/core.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -765,7 +765,7 @@ static int ci_get_platdata(struct device *dev,

		ext_id = ERR_PTR(-ENODEV);
		ext_vbus = ERR_PTR(-ENODEV);
		if (of_property_read_bool(dev->of_node, "extcon")) {
		if (of_property_present(dev->of_node, "extcon")) {
		/* Each one of them is not mandatory */
		ext_vbus = extcon_get_edev_by_phandle(dev, 0);
		if (IS_ERR(ext_vbus) && PTR_ERR(ext_vbus) != -ENODEV)

drivers/usb/dwc3/core.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1941,7 +1941,7 @@ static struct extcon_dev dwc3_get_extcon(struct dwc3 dwc)
		struct extcon_dev *edev = NULL;
		const char *name;

		if (device_property_read_bool(dev, "extcon"))
		if (device_property_present(dev, "extcon"))
		return extcon_get_edev_by_phandle(dev, 0);

		/*

drivers/usb/dwc3/dwc3-omap.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -416,7 +416,7 @@ static int dwc3_omap_extcon_register(struct dwc3_omap *omap)
		struct device_node *node = omap->dev->of_node;
		struct extcon_dev *edev;

		if (of_property_read_bool(node, "extcon")) {
		if (of_property_present(node, "extcon")) {
		edev = extcon_get_edev_by_phandle(omap->dev, 0);
		if (IS_ERR(edev)) {
		dev_vdbg(omap->dev, "couldn't get extcon device\n");

drivers/usb/dwc3/dwc3-qcom.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -161,7 +161,7 @@ static int dwc3_qcom_register_extcon(struct dwc3_qcom *qcom)
		struct extcon_dev *host_edev;
		int ret;

		if (!of_property_read_bool(dev->of_node, "extcon"))
		if (!of_property_present(dev->of_node, "extcon"))
		return 0;

		qcom->edev = extcon_get_edev_by_phandle(dev, 0);

drivers/usb/mtu3/mtu3_plat.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -307,7 +307,7 @@ static int get_ssusb_rscs(struct platform_device pdev, struct ssusb_mtk ssusb)
		if (otg_sx->role_sw_used \|\| otg_sx->manual_drd_enabled)
		goto out;

		if (of_property_read_bool(node, "extcon")) {
		if (of_property_present(node, "extcon")) {
		otg_sx->edev = extcon_get_edev_by_phandle(ssusb->dev, 0);
		if (IS_ERR(otg_sx->edev)) {
		return dev_err_probe(dev, PTR_ERR(otg_sx->edev),