Commit 7002b526 authored by Dan Carpenter's avatar Dan Carpenter Committed by Greg Kroah-Hartman
Browse files

staging: gdm724x: check for overflow in gdm_lte_netif_rx() 



This code assumes that "len" is at least 62 bytes, but we need a check
to prevent a read overflow.

Fixes: 61e12104 ("staging: gdm7240: adding LTE USB driver")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/YMcoTPsCYlhh2TQo@mwanda


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 4a36e160

drivers/staging/gdm724x/gdm_lte.c

+6 −4
Original line number Diff line number Diff line
@@ -611,10 +611,12 @@ static void gdm_lte_netif_rx(struct net_device *dev, char *buf, 
						  * bytes (99,130,83,99 dec)

						  */

			} __packed;

			void *addr = buf + sizeof(struct iphdr) +

			int offset = sizeof(struct iphdr) +

				     sizeof(struct udphdr) +

				     offsetof(struct dhcp_packet, chaddr);

			ether_addr_copy(nic->dest_mac_addr, addr);

			if (offset + ETH_ALEN > len)

				return;

			ether_addr_copy(nic->dest_mac_addr, buf + offset);

		}

	}