Commit 70138034 authored by Kaushlendra Kumar's avatar Kaushlendra Kumar Committed by Andrew Morton
Browse files

tools/mm/page_owner_sort: fix timestamp comparison for stable sorting 

The ternary operator in compare_ts() returns 1 when timestamps are equal,
causing unstable sorting behavior. Replace with explicit three-way
comparison that returns 0 for equal timestamps, ensuring stable qsort
ordering and consistent output.

Link: https://lkml.kernel.org/r/20251209044552.3396468-1-kaushlendra.kumar@intel.com


Fixes: 8f9c447e ("tools/vm/page_owner_sort.c: support sorting pid and time")
Signed-off-by: default avatarKaushlendra Kumar <kaushlendra.kumar@intel.com>
Cc: Chongxi Zhao <zhaochongxi2019@email.szu.edu.cn>
Cc: <stable@vger.kernel.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent 632b874d

tools/mm/page_owner_sort.c

+5 −1
Original line number Diff line number Diff line
@@ -181,7 +181,11 @@ static int compare_ts(const void *p1, const void *p2) 
{

	const struct block_list *l1 = p1, *l2 = p2;



	return l1->ts_nsec < l2->ts_nsec ? -1 : 1;

	if (l1->ts_nsec < l2->ts_nsec)

		return -1;

	if (l1->ts_nsec > l2->ts_nsec)

		return 1;

	return 0;

}



static int compare_cull_condition(const void *p1, const void *p2)