Commit 70358641 authored by Matthew Wilcox (Oracle)'s avatar Matthew Wilcox (Oracle)
Browse files

idr test suite: Take RCU read lock in idr_find_test_1 



When run on a single CPU, this test would frequently access already-freed
memory.  Due to timing, this bug never showed up on multi-CPU tests.

Reported-by: default avatarChris von Recklinghausen <crecklin@redhat.com>
Signed-off-by: default avatarMatthew Wilcox (Oracle) <willy@infradead.org>
parent 1bb4bd26

tools/testing/radix-tree/idr-test.c

+4 −0
Original line number Diff line number Diff line
@@ -306,11 +306,15 @@ void idr_find_test_1(int anchor_id, int throbber_id) 
	BUG_ON(idr_alloc(&find_idr, xa_mk_value(anchor_id), anchor_id,

				anchor_id + 1, GFP_KERNEL) != anchor_id);



	rcu_read_lock();

	do {

		int id = 0;

		void *entry = idr_get_next(&find_idr, &id);

		rcu_read_unlock();

		BUG_ON(entry != xa_mk_value(id));

		rcu_read_lock();

	} while (time(NULL) < start + 11);

	rcu_read_unlock();



	pthread_join(throbber, NULL);