Commit 70656552 authored by Mark Pearson's avatar Mark Pearson Committed by Hans de Goede
Browse files

platform/x86: think-lmi: Clean up display of current_value on Thinkstation 

On ThinkStations on retrieving the attribute value the BIOS appends the
possible values to the string.
Clean up the display in the current_value_show function so the options
part is not displayed.

Fixes: a40cd7ef ("platform/x86: think-lmi: Add WMI interface support on Lenovo platforms")
Reported by Mario Limoncello <Mario.Limonciello@amd.com>
Link: https://github.com/fwupd/fwupd/issues/5077#issuecomment-1488730526


Signed-off-by: default avatarMark Pearson <mpearson-lenovo@squebb.ca>
Link: https://lore.kernel.org/r/20230403013120.2105-2-mpearson-lenovo@squebb.ca


Tested-by: default avatarMario Limonciello <mario.limonciello@amd.com>
Tested-by: default avatarMirsad Goran Todorovac <mirsad.todorovac@alu.unizg.hr>
Reviewed-by: default avatarHans de Goede <hdegoede@redhat.com>
Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
parent e7d796fc

drivers/platform/x86/think-lmi.c

+6 −3
Original line number Diff line number Diff line
@@ -920,7 +920,7 @@ static ssize_t display_name_show(struct kobject *kobj, struct kobj_attribute *at 
static ssize_t current_value_show(struct kobject *kobj, struct kobj_attribute *attr, char *buf)

{

	struct tlmi_attr_setting *setting = to_tlmi_attr_setting(kobj);

	char *item, *value;

	char *item, *value, *p;

	int ret;



	ret = tlmi_setting(setting->index, &item, LENOVO_BIOS_SETTING_GUID);
@@ -931,9 +931,12 @@ static ssize_t current_value_show(struct kobject *kobj, struct kobj_attribute *a 
	value = strpbrk(item, ",");

	if (!value || value == item || !strlen(value + 1))

		ret = -EINVAL;

	else

	else {

		/* On Workstations remove the Options part after the value */

		p = strchrnul(value, ';');

		*p = '\0';

		ret = sysfs_emit(buf, "%s\n", value + 1);



	}

	kfree(item);



	return ret;