Commit 70685c29 authored by Darrick J. Wong's avatar Darrick J. Wong Committed by Carlos Maiolino
Browse files

xfs: don't irele after failing to iget in xfs_attri_recover_work 



xlog_recovery_iget* never set @ip to a valid pointer if they return
an error, so this irele will walk off a dangling pointer.  Fix that.

Cc: stable@vger.kernel.org # v6.10
Fixes: ae673f53 ("xfs: record inode generation in xattr update log intent items")
Signed-off-by: default avatarDarrick J. Wong <djwong@kernel.org>
Reviewed-by: default avatarLong Li <leo.lilong@huawei.com>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Reviewed-by: default avatarCarlos Maiolino <cmaiolino@redhat.com>
Signed-off-by: default avatarCarlos Maiolino <cem@kernel.org>
parent c6c56ff9

fs/xfs/xfs_attr_item.c

+0 −1
Original line number Diff line number Diff line
@@ -653,7 +653,6 @@ xfs_attri_recover_work( 
		break;

	}

	if (error) {

		xfs_irele(ip);

		XFS_CORRUPTION_ERROR(__func__, XFS_ERRLEVEL_LOW, mp, attrp,

				sizeof(*attrp));

		return ERR_PTR(-EFSCORRUPTED);