Commit 706a0663 authored by Dmitry Torokhov's avatar Dmitry Torokhov
Browse files

Input: samsung-keypad - do not combine memory allocation checks 



The driver uses devm API to allocate resources so there's no reason
to do allocations first and then check and release everything at once.

Check results immediately after doing allocation of each resource.

Reviewed-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://lore.kernel.org/r/20240819045813.2154642-4-dmitry.torokhov@gmail.com


Signed-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
parent 4d4d74c6

drivers/input/keyboard/samsung-keypad.c

+4 −1
Original line number Diff line number Diff line
@@ -349,8 +349,11 @@ static int samsung_keypad_probe(struct platform_device *pdev) 


	keypad = devm_kzalloc(&pdev->dev, sizeof(*keypad) + keymap_size,

			      GFP_KERNEL);

	if (!keypad)

		return -ENOMEM;



	input_dev = devm_input_allocate_device(&pdev->dev);

	if (!keypad || !input_dev)

	if (!input_dev)

		return -ENOMEM;



	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);