Commit 706cc5a9 authored by Nirbhay Sharma's avatar Nirbhay Sharma Committed by Greg Kroah-Hartman
Browse files

staging: greybus: uart: check return values during probe 



Check the return values of send_control() and send_line_coding() during
device initialization in gb_uart_probe(). If these operations fail, the
device will be left in an inconsistent state, so propagate the error to
properly fail the probe.

Both functions call gb_operation_sync() which can fail with errors such
as -ENOMEM, -ENODEV, or -ETIMEDOUT. Ignoring these errors means the TTY
device would be registered despite incomplete initialization.

Signed-off-by: default avatarNirbhay Sharma <nirbhay.lkd@gmail.com>
Link: https://patch.msgid.link/20251115061646.160847-2-nirbhay.lkd@gmail.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 47d3949a

drivers/staging/greybus/uart.c

+6 −2
Original line number Diff line number Diff line
@@ -879,14 +879,18 @@ static int gb_uart_probe(struct gbphy_device *gbphy_dev, 
	if (retval)

		goto exit_put_port;



	send_control(gb_tty, gb_tty->ctrlout);

	retval = send_control(gb_tty, gb_tty->ctrlout);

	if (retval)

		goto exit_connection_disable;



	/* initialize the uart to be 9600n81 */

	gb_tty->line_coding.rate = cpu_to_le32(9600);

	gb_tty->line_coding.format = GB_SERIAL_1_STOP_BITS;

	gb_tty->line_coding.parity = GB_SERIAL_NO_PARITY;

	gb_tty->line_coding.data_bits = 8;

	send_line_coding(gb_tty);

	retval = send_line_coding(gb_tty);

	if (retval)

		goto exit_connection_disable;



	retval = gb_connection_enable(connection);

	if (retval)