Commit 70812056 authored by Val Packett's avatar Val Packett Committed by Vinod Koul
Browse files

phy: qcom: edp: Fix NULL pointer dereference for phy v6 (x1e80100) 



For Glymur SoC support, the com_clk_fwd_cfg callback was added, and a
stub implementation was added for the v4 of the hardware. However it
was omitted for the v6, causing a NULL pointer dereference oops on
Hamoa/Purwa (X1E/X1P) SoC devices. Fix by adding the appropriate stub.

Fixes: add66a66 ("phy: qcom: edp: Add Glymur platform support")
Reviewed-by: default avatarAbel Vesa <abel.vesa@oss.qualcomm.com>
Signed-off-by: default avatarVal Packett <val@packett.cool>
Reviewed-by: default avatarNeil Armstrong <neil.armstrong@linaro.org>
Reviewed-by: default avatarDmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Reviewed-by: default avatarKonrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Tested-by: Yijie Yang <yijie.yang@oss.qualcomm.com> # Purwa-IoT-EVK
Link: https://patch.msgid.link/20260111083317.604754-1-val@packett.cool


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent a6998089

drivers/phy/qualcomm/phy-qcom-edp.c

+1 −0
Original line number Diff line number Diff line
@@ -758,6 +758,7 @@ static const struct phy_ver_ops qcom_edp_phy_ops_v6 = { 
	.com_power_on		= qcom_edp_phy_power_on_v6,

	.com_resetsm_cntrl	= qcom_edp_phy_com_resetsm_cntrl_v6,

	.com_bias_en_clkbuflr	= qcom_edp_com_bias_en_clkbuflr_v6,

	.com_clk_fwd_cfg	= qcom_edp_com_clk_fwd_cfg_v4,

	.com_configure_pll	= qcom_edp_com_configure_pll_v6,

	.com_configure_ssc	= qcom_edp_com_configure_ssc_v6,

};