Commit 70cb6ca5 authored Jul 12, 2025 by Eric Biggers

lib/crypto: arm/sha1: Migrate optimized code into library



Instead of exposing the arm-optimized SHA-1 code via arm-specific
crypto_shash algorithms, instead just implement the sha1_blocks()
library function.  This is much simpler, it makes the SHA-1 library
functions be arm-optimized, and it fixes the longstanding issue where
the arm-optimized SHA-1 code was disabled by default.  SHA-1 still
remains available through crypto_shash, but individual architectures no
longer need to handle it.

To match sha1_blocks(), change the type of the nblocks parameter of the
assembly functions from int to size_t.  The assembly functions actually
already treated it as size_t.

Reviewed-by: Ard Biesheuvel <ardb@kernel.org>
Link: https://lore.kernel.org/r/20250712232329.818226-8-ebiggers@kernel.org


Signed-off-by: Eric Biggers <ebiggers@kernel.org>

parent b10a74ab

arch/arm/configs/exynos_defconfig

+0 −1

Original line number	Diff line number	Diff line
		@@ -363,7 +363,6 @@ CONFIG_CRYPTO_USER_API_HASH=m
		CONFIG_CRYPTO_USER_API_SKCIPHER=m
		CONFIG_CRYPTO_USER_API_RNG=m
		CONFIG_CRYPTO_USER_API_AEAD=m
		CONFIG_CRYPTO_SHA1_ARM_NEON=m
		CONFIG_CRYPTO_AES_ARM_BS=m
		CONFIG_CRYPTO_CHACHA20_NEON=m
		CONFIG_CRYPTO_DEV_EXYNOS_RNG=y

arch/arm/configs/milbeaut_m10v_defconfig

+0 −2

Original line number	Diff line number	Diff line
		@@ -98,8 +98,6 @@ CONFIG_CRYPTO_SELFTESTS=y
		CONFIG_CRYPTO_AES=y
		CONFIG_CRYPTO_SEQIV=m
		CONFIG_CRYPTO_GHASH_ARM_CE=m
		CONFIG_CRYPTO_SHA1_ARM_NEON=m
		CONFIG_CRYPTO_SHA1_ARM_CE=m
		CONFIG_CRYPTO_AES_ARM=m
		CONFIG_CRYPTO_AES_ARM_BS=m
		CONFIG_CRYPTO_AES_ARM_CE=m

arch/arm/configs/multi_v7_defconfig

+0 −2

Original line number	Diff line number	Diff line
		@@ -1280,8 +1280,6 @@ CONFIG_CRYPTO_USER_API_SKCIPHER=m
		CONFIG_CRYPTO_USER_API_RNG=m
		CONFIG_CRYPTO_USER_API_AEAD=m
		CONFIG_CRYPTO_GHASH_ARM_CE=m
		CONFIG_CRYPTO_SHA1_ARM_NEON=m
		CONFIG_CRYPTO_SHA1_ARM_CE=m
		CONFIG_CRYPTO_AES_ARM=m
		CONFIG_CRYPTO_AES_ARM_BS=m
		CONFIG_CRYPTO_AES_ARM_CE=m

arch/arm/configs/omap2plus_defconfig

+0 −1

Original line number	Diff line number	Diff line
		@@ -704,7 +704,6 @@ CONFIG_NLS_ISO8859_1=y
		CONFIG_SECURITY=y
		CONFIG_CRYPTO_MICHAEL_MIC=y
		CONFIG_CRYPTO_GHASH_ARM_CE=m
		CONFIG_CRYPTO_SHA1_ARM_NEON=m
		CONFIG_CRYPTO_AES_ARM=m
		CONFIG_CRYPTO_AES_ARM_BS=m
		CONFIG_CRYPTO_CHACHA20_NEON=m

arch/arm/configs/pxa_defconfig

+0 −1

Original line number	Diff line number	Diff line
		@@ -658,7 +658,6 @@ CONFIG_CRYPTO_ANUBIS=m
		CONFIG_CRYPTO_XCBC=m
		CONFIG_CRYPTO_DEFLATE=y
		CONFIG_CRYPTO_LZO=y
		CONFIG_CRYPTO_SHA1_ARM=m
		CONFIG_CRYPTO_AES_ARM=m
		CONFIG_FONTS=y
		CONFIG_FONT_8x8=y