Commit 70d99623 authored by Ivan Vecera's avatar Ivan Vecera Committed by Jakub Kicinski
Browse files

dpll: fix clock quality level reporting 



The DPLL_CLOCK_QUALITY_LEVEL_ITU_OPT1_EPRC is not reported via netlink
due to bug in dpll_msg_add_clock_quality_level(). The usage of
DPLL_CLOCK_QUALITY_LEVEL_MAX for both DECLARE_BITMAP() and
for_each_set_bit() is not correct because these macros requires bitmap
size and not the highest valid bit in the bitmap.

Use correct bitmap size to fix this issue.

Fixes: a1afb959 ("dpll: add clock quality level attribute and op")
Signed-off-by: default avatarIvan Vecera <ivecera@redhat.com>
Reviewed-by: default avatarArkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>
Link: https://patch.msgid.link/20250912093331.862333-1-ivecera@redhat.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 2e7bba08

drivers/dpll/dpll_netlink.c

+2 −2
Original line number Diff line number Diff line
@@ -211,8 +211,8 @@ static int 
dpll_msg_add_clock_quality_level(struct sk_buff *msg, struct dpll_device *dpll,

				 struct netlink_ext_ack *extack)

{

	DECLARE_BITMAP(qls, DPLL_CLOCK_QUALITY_LEVEL_MAX + 1) = { 0 };

	const struct dpll_device_ops *ops = dpll_device_ops(dpll);

	DECLARE_BITMAP(qls, DPLL_CLOCK_QUALITY_LEVEL_MAX) = { 0 };

	enum dpll_clock_quality_level ql;

	int ret;
@@ -221,7 +221,7 @@ dpll_msg_add_clock_quality_level(struct sk_buff *msg, struct dpll_device *dpll, 
	ret = ops->clock_quality_level_get(dpll, dpll_priv(dpll), qls, extack);

	if (ret)

		return ret;

	for_each_set_bit(ql, qls, DPLL_CLOCK_QUALITY_LEVEL_MAX)

	for_each_set_bit(ql, qls, DPLL_CLOCK_QUALITY_LEVEL_MAX + 1)

		if (nla_put_u32(msg, DPLL_A_CLOCK_QUALITY_LEVEL, ql))

			return -EMSGSIZE;