Unverified Commit 7118daab authored by Christian Brauner's avatar Christian Brauner
Browse files

ns: add asserts for initial namespace active reference counts 

They always remain fixed at one. Notice when that assumptions is broken.

Link: https://patch.msgid.link/20251110-work-namespace-nstree-fixes-v1-14-e8a9264e0fb9@kernel.org


Signed-off-by: default avatarChristian Brauner <brauner@kernel.org>
parent 2b60d56a

include/linux/ns_common.h

+4 −0
Original line number Diff line number Diff line
@@ -69,6 +69,7 @@ static __always_inline __must_check bool __ns_ref_put(struct ns_common *ns) 
{

	if (is_ns_init_id(ns)) {

		VFS_WARN_ON_ONCE(__ns_ref_read(ns) != 1);

		VFS_WARN_ON_ONCE(__ns_ref_active_read(ns) != 1);

		return false;

	}

	if (refcount_dec_and_test(&ns->__ns_ref)) {
@@ -82,6 +83,7 @@ static __always_inline __must_check bool __ns_ref_get(struct ns_common *ns) 
{

	if (is_ns_init_id(ns)) {

		VFS_WARN_ON_ONCE(__ns_ref_read(ns) != 1);

		VFS_WARN_ON_ONCE(__ns_ref_active_read(ns) != 1);

		return true;

	}

	if (refcount_inc_not_zero(&ns->__ns_ref))
@@ -94,6 +96,7 @@ static __always_inline void __ns_ref_inc(struct ns_common *ns) 
{

	if (is_ns_init_id(ns)) {

		VFS_WARN_ON_ONCE(__ns_ref_read(ns) != 1);

		VFS_WARN_ON_ONCE(__ns_ref_active_read(ns) != 1);

		return;

	}

	refcount_inc(&ns->__ns_ref);
@@ -104,6 +107,7 @@ static __always_inline __must_check bool __ns_ref_dec_and_lock(struct ns_common 
{

	if (is_ns_init_id(ns)) {

		VFS_WARN_ON_ONCE(__ns_ref_read(ns) != 1);

		VFS_WARN_ON_ONCE(__ns_ref_active_read(ns) != 1);

		return false;

	}

	return refcount_dec_and_lock(&ns->__ns_ref, ns_lock);