Commit 7157062b authored by Masami Hiramatsu (Google)'s avatar Masami Hiramatsu (Google) Committed by Steven Rostedt (Google)
Browse files

tracing: Report wrong dynamic event command 

Report wrong dynamic event type in the command via error_log.
-----
 # echo "z hoge" > /sys/kernel/tracing/dynamic_events
 sh: write error: Invalid argument
 # cat /sys/kernel/tracing/error_log
 [   22.977022] dynevent: error: No matching dynamic event type
   Command: z hoge
            ^
-----

Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Link: https://patch.msgid.link/176278970056.343441.10528135217342926645.stgit@devnote2


Signed-off-by: default avatarMasami Hiramatsu (Google) <mhiramat@kernel.org>
Signed-off-by: default avatarSteven Rostedt (Google) <rostedt@goodmis.org>
parent 3a0d5bc7

kernel/trace/trace_dynevent.c

+9 −2
Original line number Diff line number Diff line
@@ -144,9 +144,16 @@ static int create_dyn_event(const char *raw_command) 
		if (!ret || ret != -ECANCELED)

			break;

	}

	mutex_unlock(&dyn_event_ops_mutex);

	if (ret == -ECANCELED)

	if (ret == -ECANCELED) {

		static const char *err_msg[] = {"No matching dynamic event type"};



		/* Wrong dynamic event. Leave an error message. */

		tracing_log_err(NULL, "dynevent", raw_command, err_msg,

				0, 0);

		ret = -EINVAL;

	}



	mutex_unlock(&dyn_event_ops_mutex);



	return ret;

}