Commit 720f8db8 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Daniel Lezcano
Browse files

thermal: amlogic: Make amlogic_thermal_disable() return void 



amlogic_thermal_disable() returned zero unconditionally and
amlogic_thermal_remove() already ignores the return value.

Make it return no value and modify amlogic_thermal_suspend to not check
the value.

This patch introduces no semantic changes, but makes it more obvious for
a human reader that amlogic_thermal_suspend() cannot fail.

Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: default avatarDaniel Lezcano <daniel.lezcano@linaro.org>
Link: https://lore.kernel.org/r/20231116112633.668826-2-u.kleine-koenig@pengutronix.de
parent 62e79e38

drivers/thermal/amlogic_thermal.c

+4 −4
Original line number Diff line number Diff line
@@ -167,13 +167,11 @@ static int amlogic_thermal_enable(struct amlogic_thermal *data) 
	return 0;

}



static int amlogic_thermal_disable(struct amlogic_thermal *data)

static void amlogic_thermal_disable(struct amlogic_thermal *data)

{

	regmap_update_bits(data->regmap, TSENSOR_CFG_REG1,

			   TSENSOR_CFG_REG1_ENABLE, 0);

	clk_disable_unprepare(data->clk);



	return 0;

}



static int amlogic_thermal_get_temp(struct thermal_zone_device *tz, int *temp)
@@ -302,7 +300,9 @@ static int __maybe_unused amlogic_thermal_suspend(struct device *dev) 
{

	struct amlogic_thermal *data = dev_get_drvdata(dev);



	return amlogic_thermal_disable(data);

	amlogic_thermal_disable(data);



	return 0;

}



static int __maybe_unused amlogic_thermal_resume(struct device *dev)