Commit 722d343f authored by Filipe Manana's avatar Filipe Manana Committed by David Sterba
Browse files

btrfs: remove check for NULL fs_info at btrfs_folio_end_lock_bitmap() 



Smatch complains about possibly dereferencing a NULL fs_info at
btrfs_folio_end_lock_bitmap():

  fs/btrfs/subpage.c:332 btrfs_folio_end_lock_bitmap() warn: variable dereferenced before check 'fs_info' (see line 326)

because we access fs_info to set the 'start_bit' variable before doing the
check for a NULL fs_info.

However fs_info is never NULL, since in the only caller of
btrfs_folio_end_lock_bitmap() is extent_writepage(), where we have an
inode which always as a non-NULL fs_info.

So remove the check for a NULL fs_info at btrfs_folio_end_lock_bitmap().

Reviewed-by: default avatarQu Wenruo <wqu@suse.com>
Signed-off-by: default avatarFilipe Manana <fdmanana@suse.com>
Reviewed-by: default avatarDavid Sterba <dsterba@suse.com>
Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
parent 2342d659

fs/btrfs/subpage.c

+1 −1
Original line number Diff line number Diff line
@@ -329,7 +329,7 @@ void btrfs_folio_end_lock_bitmap(const struct btrfs_fs_info *fs_info, 
	int cleared = 0;

	int bit;



	if (unlikely(!fs_info) || !btrfs_is_subpage(fs_info, folio->mapping)) {

	if (!btrfs_is_subpage(fs_info, folio->mapping)) {

		folio_unlock(folio);

		return;

	}