Commit 72741db6 authored by Thorsten Blum's avatar Thorsten Blum Committed by Andrew Morton
Browse files

mm: page_alloc: use div64_ul() instead of do_div() 

Fixes Coccinelle/coccicheck warning reported by do_div.cocci.

Compared to do_div(), div64_ul() does not implicitly cast the divisor and
does not unnecessarily calculate the remainder.

Link: https://lkml.kernel.org/r/20240228224911.1164-2-thorsten.blum@toblux.com


Signed-off-by: default avatarThorsten Blum <thorsten.blum@toblux.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent f1cce6f7

mm/page_alloc.c

+1 −1
Original line number Diff line number Diff line
@@ -5848,7 +5848,7 @@ static void __setup_per_zone_wmarks(void) 


		spin_lock_irqsave(&zone->lock, flags);

		tmp = (u64)pages_min * zone_managed_pages(zone);

		do_div(tmp, lowmem_pages);

		tmp = div64_ul(tmp, lowmem_pages);

		if (is_highmem(zone) || zone_idx(zone) == ZONE_MOVABLE) {

			/*

			 * __GFP_HIGH and PF_MEMALLOC allocations usually don't