Unverified Commit 7299cc06 authored by Thorsten Blum's avatar Thorsten Blum Committed by Mark Brown
Browse files

ASoC: SOF: Intel: Use str_yes_no() to improve bdw_dump() 



Remove hard-coded strings by using the str_yes_no() helper function.

Signed-off-by: default avatarThorsten Blum <thorsten.blum@linux.dev>
Link: https://patch.msgid.link/20250107110900.3716-2-thorsten.blum@linux.dev


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent abea0cbf

sound/soc/sof/intel/bdw.c

+8 −8
Original line number Diff line number Diff line
@@ -266,20 +266,20 @@ static void bdw_dump(struct snd_sof_dev *sdev, u32 flags) 
	imrd = snd_sof_dsp_read(sdev, BDW_DSP_BAR, SHIM_IMRD);

	dev_err(sdev->dev,

		"error: ipc host -> DSP: pending %s complete %s raw 0x%8.8x\n",

		(panic & SHIM_IPCX_BUSY) ? "yes" : "no",

		(panic & SHIM_IPCX_DONE) ? "yes" : "no", panic);

		str_yes_no(panic & SHIM_IPCX_BUSY),

		str_yes_no(panic & SHIM_IPCX_DONE), panic);

	dev_err(sdev->dev,

		"error: mask host: pending %s complete %s raw 0x%8.8x\n",

		(imrx & SHIM_IMRX_BUSY) ? "yes" : "no",

		(imrx & SHIM_IMRX_DONE) ? "yes" : "no", imrx);

		str_yes_no(imrx & SHIM_IMRX_BUSY),

		str_yes_no(imrx & SHIM_IMRX_DONE), imrx);

	dev_err(sdev->dev,

		"error: ipc DSP -> host: pending %s complete %s raw 0x%8.8x\n",

		(status & SHIM_IPCD_BUSY) ? "yes" : "no",

		(status & SHIM_IPCD_DONE) ? "yes" : "no", status);

		str_yes_no(status & SHIM_IPCD_BUSY),

		str_yes_no(status & SHIM_IPCD_DONE), status);

	dev_err(sdev->dev,

		"error: mask DSP: pending %s complete %s raw 0x%8.8x\n",

		(imrd & SHIM_IMRD_BUSY) ? "yes" : "no",

		(imrd & SHIM_IMRD_DONE) ? "yes" : "no", imrd);

		str_yes_no(imrd & SHIM_IMRD_BUSY),

		str_yes_no(imrd & SHIM_IMRD_DONE), imrd);

}



/*