Commit 729a2e8e authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Will Deacon
Browse files

arm64: hugetlbpage: avoid unused-but-set-parameter warning (gcc-16) 



gcc-16 warns about an instance that older compilers did not:

arch/arm64/mm/hugetlbpage.c: In function 'huge_pte_clear':
arch/arm64/mm/hugetlbpage.c:369:57: error: parameter 'addr' set but not used [-Werror=unused-but-set-parameter=]

The issue here is that __pte_clear() does not actually use its second
argument, but when CONFIG_ARM64_CONTPTE is enabled it still gets
updated.

Replace the macro with an inline function to let the compiler see
the argument getting passed down.

Suggested-by: default avatarCatalin Marinas <catalin.marinas@arm.com>
Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Reviewed-by: default avatarDev Jain <dev.jain@arm.com>
Signed-off-by: default avatarWill Deacon <will@kernel.org>
parent 29cc0f3a

arch/arm64/include/asm/pgtable.h

+7 −2
Original line number Diff line number Diff line
@@ -179,8 +179,6 @@ static inline pteval_t __phys_to_pte_val(phys_addr_t phys) 
	__pte(__phys_to_pte_val((phys_addr_t)(pfn) << PAGE_SHIFT) | pgprot_val(prot))



#define pte_none(pte)		(!pte_val(pte))

#define __pte_clear(mm, addr, ptep) \

				__set_pte(ptep, __pte(0))

#define pte_page(pte)		(pfn_to_page(pte_pfn(pte)))



/*
@@ -1320,6 +1318,13 @@ static inline bool pud_user_accessible_page(pud_t pud) 
/*

 * Atomic pte/pmd modifications.

 */



static inline void __pte_clear(struct mm_struct *mm,

			       unsigned long addr, pte_t *ptep)

{

	__set_pte(ptep, __pte(0));

}



static inline int __ptep_test_and_clear_young(struct vm_area_struct *vma,

					      unsigned long address,

					      pte_t *ptep)