Commit 72b8654e authored by Willmar Knikker's avatar Willmar Knikker Committed by Jeff Johnson
Browse files

wifi: ath11k: fix use after free in ath11k_dp_rx_msdu_coalesce() 



In ath11k_dp_rx_msdu_coalesce() the loop uses ->is_continuation after
the dev_kfree_skb_any(). This can cause a use after free kfence.

Use flag for caching is_continuation for use after the
dev_kfree_skb_any().

Fixes: d5c65159 ("ath11k: driver for Qualcomm IEEE 802.11ax devices")
Signed-off-by: default avatarWillmar Knikker <willmar@met-dubbel-l.nl>
Reviewed-by: default avatarBaochen Qiang <baochen.qiang@oss.qualcomm.com>
Reviewed-by: default avatarRameshkumar Sundaram <rameshkumar.sundaram@oss.qualcomm.com>
Link: https://patch.msgid.link/20260505171709.547274-1-willmar@met-dubbel-l.nl


Signed-off-by: default avatarJeff Johnson <jeff.johnson@oss.qualcomm.com>
parent 2a2451a3

drivers/net/wireless/ath/ath11k/dp_rx.c

+4 −2
Original line number Diff line number Diff line
@@ -1761,6 +1761,7 @@ static int ath11k_dp_rx_msdu_coalesce(struct ath11k *ar, 
	int buf_first_hdr_len, buf_first_len;

	struct hal_rx_desc *ldesc;

	int space_extra, rem_len, buf_len;

	bool is_continuation;

	u32 hal_rx_desc_sz = ar->ab->hw_params.hal_desc_sz;



	/* As the msdu is spread across multiple rx buffers,
@@ -1810,7 +1811,8 @@ static int ath11k_dp_rx_msdu_coalesce(struct ath11k *ar, 
	rem_len = msdu_len - buf_first_len;

	while ((skb = __skb_dequeue(msdu_list)) != NULL && rem_len > 0) {

		rxcb = ATH11K_SKB_RXCB(skb);

		if (rxcb->is_continuation)

		is_continuation = rxcb->is_continuation;

		if (is_continuation)

			buf_len = DP_RX_BUFFER_SIZE - hal_rx_desc_sz;

		else

			buf_len = rem_len;
@@ -1828,7 +1830,7 @@ static int ath11k_dp_rx_msdu_coalesce(struct ath11k *ar, 
		dev_kfree_skb_any(skb);



		rem_len -= buf_len;

		if (!rxcb->is_continuation)

		if (!is_continuation)

			break;

	}