Commit 72c1afff authored by Rafael J. Wysocki's avatar Rafael J. Wysocki
Browse files

thermal/debugfs: Free all thermal zone debug memory on zone removal 



Because thermal_debug_tz_remove() does not free all memory allocated for
thermal zone diagnostics, some of that memory becomes unreachable after
freeing the thermal zone's struct thermal_debugfs object.

Address this by making thermal_debug_tz_remove() free all of the memory
in question.

Fixes: 7ef01f22 ("thermal/debugfs: Add thermal debugfs information for mitigation episodes")
Cc :6.8+ <stable@vger.kernel.org> # 6.8+
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
Reviewed-by: default avatarLukasz Luba <lukasz.luba@arm.com>
parent ed30a4a5

drivers/thermal/thermal_debugfs.c

+13 −0
Original line number Diff line number Diff line
@@ -826,15 +826,28 @@ void thermal_debug_tz_add(struct thermal_zone_device *tz) 
void thermal_debug_tz_remove(struct thermal_zone_device *tz)

{

	struct thermal_debugfs *thermal_dbg = tz->debugfs;

	struct tz_episode *tze, *tmp;

	struct tz_debugfs *tz_dbg;

	int *trips_crossed;



	if (!thermal_dbg)

		return;



	tz_dbg = &thermal_dbg->tz_dbg;



	mutex_lock(&thermal_dbg->lock);



	trips_crossed = tz_dbg->trips_crossed;



	list_for_each_entry_safe(tze, tmp, &tz_dbg->tz_episodes, node) {

		list_del(&tze->node);

		kfree(tze);

	}



	tz->debugfs = NULL;



	mutex_unlock(&thermal_dbg->lock);



	thermal_debugfs_remove_id(thermal_dbg);

	kfree(trips_crossed);

}