Commit 72e008ce authored by Dan Carpenter's avatar Dan Carpenter Committed by Greg Kroah-Hartman
Browse files

nvmem: core: Fix a resource leak on error in nvmem_add_cells_from_of() 



This doesn't call of_node_put() on the error path so it leads to a
memory leak.

Fixes: 0749aa25 ("nvmem: core: fix regression in of_nvmem_cell_get()")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarSrinivas Kandagatla <srinivas.kandagatla@linaro.org>
Link: https://lore.kernel.org/r/20210129171430.11328-2-srinivas.kandagatla@linaro.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 76ec1ec8

drivers/nvmem/core.c

+1 −0
Original line number Diff line number Diff line
@@ -713,6 +713,7 @@ static int nvmem_add_cells_from_of(struct nvmem_device *nvmem) 
				cell->name, nvmem->stride);

			/* Cells already added will be freed later. */

			kfree_const(cell->name);

			of_node_put(cell->np);

			kfree(cell);

			return -EINVAL;

		}