Commit 72e1c440 authored by Andy Shevchenko's avatar Andy Shevchenko
Browse files

auxdisplay: panel: Fix an API misuse in panel.c 



Variable allocated by charlcd_alloc() should be released
by charlcd_free(). The following patch changed kfree() to
charlcd_free() to fix an API misuse.

Reviewed-by: default avatarGeert Uytterhoeven <geert@linux-m68k.org>
Fixes: 718e05ed ("auxdisplay: Introduce hd44780_common.[ch]")
Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
parent 9b98a7d2

drivers/auxdisplay/panel.c

+2 −2
Original line number Diff line number Diff line
@@ -1664,7 +1664,7 @@ static void panel_attach(struct parport *port) 
	if (lcd.enabled)

		charlcd_unregister(lcd.charlcd);

err_unreg_device:

	kfree(lcd.charlcd);

	charlcd_free(lcd.charlcd);

	lcd.charlcd = NULL;

	parport_unregister_device(pprt);

	pprt = NULL;
@@ -1692,7 +1692,7 @@ static void panel_detach(struct parport *port) 
		charlcd_unregister(lcd.charlcd);

		lcd.initialized = false;

		kfree(lcd.charlcd->drvdata);

		kfree(lcd.charlcd);

		charlcd_free(lcd.charlcd);

		lcd.charlcd = NULL;

	}