Commit 72e5c0d7 authored by Juergen Gross's avatar Juergen Gross Committed by Guenter Roeck
Browse files

hwmon/w83781d: Drop REALLY_SLOW_IO setting 



In w83781d_isa_found() there is REALLY_SLOW_IO defined around some port
accesses, probably in order to wait between multiple accesses.

Unfortunately this isn't making any difference compared to not having
this define since more than a decade, as REALLY_SLOW_IO needs to be
defined while "#include <asm/io.h>" is called to have an effect.

As there seem not to be any outstanding issues in spite of this having
no effect, just drop the "#define" and add a remark to the related
comment.

Signed-off-by: default avatarJuergen Gross <jgross@suse.com>
Link: https://lore.kernel.org/r/20251126162018.5676-4-jgross@suse.com


Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
parent 8ac2a19d

drivers/hwmon/w83781d.c

+3 −2
Original line number Diff line number Diff line
@@ -1850,10 +1850,12 @@ w83781d_isa_found(unsigned short address) 
		}

	}



#define REALLY_SLOW_IO

	/*

	 * We need the timeouts for at least some W83781D-like

	 * chips. But only if we read 'undefined' registers.

	 * There used to be a "#define REALLY_SLOW_IO" to enforce that, but

	 * this has been without any effect since more than a decade, so it

	 * has been dropped.

	 */

	val = inb_p(address + 1);

	if (inb_p(address + 2) != val
@@ -1862,7 +1864,6 @@ w83781d_isa_found(unsigned short address) 
		pr_debug("Detection failed at step %d\n", 1);

		goto release;

	}

#undef REALLY_SLOW_IO



	/*

	 * We should be able to change the 7 LSB of the address port. The