Commit 732c6cef authored by Ce Sun's avatar Ce Sun Committed by Alex Deucher
Browse files

drm/amdgpu: Replace tmp_adev with hive in amdgpu_pci_slot_reset 



Checking hive is more readable.

The following smatch warning:
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:6820 amdgpu_pci_slot_reset()
warn: iterator used outside loop: 'tmp_adev'

Reported-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: default avatarCe Sun <cesun102@amd.com>
Reviewed-by: default avatarChristian König <christian.koenig@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 39938a8e

drivers/gpu/drm/amd/amdgpu/amdgpu_device.c

+3 −3
Original line number Diff line number Diff line
@@ -6794,8 +6794,8 @@ pci_ers_result_t amdgpu_pci_slot_reset(struct pci_dev *pdev) 
	struct drm_device *dev = pci_get_drvdata(pdev);

	struct amdgpu_device *adev = drm_to_adev(dev);

	struct amdgpu_reset_context reset_context;

	struct amdgpu_device *tmp_adev = NULL;

	struct amdgpu_hive_info *hive = NULL;

	struct amdgpu_device *tmp_adev;

	struct amdgpu_hive_info *hive;

	struct list_head device_list;

	int r = 0, i;

	u32 memsize;
@@ -6856,7 +6856,7 @@ pci_ers_result_t amdgpu_pci_slot_reset(struct pci_dev *pdev) 
		dev_info(adev->dev, "PCIe error recovery succeeded\n");

	} else {

		dev_err(adev->dev, "PCIe error recovery failed, err:%d\n", r);

		if (tmp_adev) {

		if (hive) {

			list_for_each_entry(tmp_adev, &device_list, reset_list)

				amdgpu_device_unset_mp1_state(tmp_adev);

			amdgpu_device_unlock_reset_domain(adev->reset_domain);