Unverified Commit 73580ec6 authored Apr 08, 2024 by Richard Fitzgerald Committed by Mark Brown Apr 08, 2024

ALSA: hda: cs35l56: Exit cache-only after cs35l56_wait_for_firmware_boot()



Adds calls to disable regmap cache-only after a successful return from
cs35l56_wait_for_firmware_boot().

This is to prepare for a change in the shared ASoC module that will
leave regmap in cache-only mode after cs35l56_system_reset(). This is
to prevent register accesses going to the hardware while it is
rebooting.

Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
Link: https://msgid.link/r/20240408101803.43183-3-rf@opensource.cirrus.com


Signed-off-by: Mark Brown <broonie@kernel.org>

parent 70ee853e

sound/pci/hda/cs35l56_hda.c

+4 −0

Original line number	Diff line number	Diff line
		@@ -644,6 +644,8 @@ static int cs35l56_hda_fw_load(struct cs35l56_hda *cs35l56)
		ret = cs35l56_wait_for_firmware_boot(&cs35l56->base);
		if (ret)
		goto err_powered_up;

		regcache_cache_only(cs35l56->base.regmap, false);
		}

		/* Disable auto-hibernate so that runtime_pm has control */
		@@ -1002,6 +1004,8 @@ int cs35l56_hda_common_probe(struct cs35l56_hda *cs35l56, int hid, int id)
		if (ret)
		goto err;

		regcache_cache_only(cs35l56->base.regmap, false);

		ret = cs35l56_set_patch(&cs35l56->base);
		if (ret)
		goto err;