Commit 738ec5ab authored by Kevin Hao's avatar Kevin Hao Committed by Greg Kroah-Hartman
Browse files

usb: ueagle-atm: Use wait_event_freezable_timeout() in uea_wait() 



A freezable kernel thread can enter frozen state during freezing by
either calling try_to_freeze() or using wait_event_freezable() and its
variants. So for the following snippet of code in a kernel thread loop:
  wait_event_interruptible_timeout();
  try_to_freeze();

We can change it to a simple wait_event_freezable_timeout() and
then eliminate a function call.

Signed-off-by: default avatarKevin Hao <haokexin@gmail.com>
Link: https://lore.kernel.org/r/20231218074730.1898699-1-haokexin@gmail.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 730e12fb

drivers/usb/atm/ueagle-atm.c

+1 −2
Original line number Diff line number Diff line
@@ -546,7 +546,7 @@ MODULE_PARM_DESC(annex, 


#define uea_wait(sc, cond, timeo) \

({ \

	int _r = wait_event_interruptible_timeout(sc->sync_q, \

	int _r = wait_event_freezable_timeout(sc->sync_q, \

			(cond) || kthread_should_stop(), timeo); \

	if (kthread_should_stop()) \

		_r = -ENODEV; \
@@ -1896,7 +1896,6 @@ static int uea_kthread(void *data) 
			ret = sc->stat(sc);

		if (ret != -EAGAIN)

			uea_wait(sc, 0, msecs_to_jiffies(1000));

		try_to_freeze();

	}

	uea_leaves(INS_TO_USBDEV(sc));

	return ret;