Commit 73a40554 authored by Frank Li's avatar Frank Li Committed by Hans Verkuil
Browse files

media: nxp: imx8-isi: Remove redundant check for dma_set_mask_and_coherent() 



dma_set_mask_and_coherent() never return failure when mask bigger than
32bit.

See commit f7ae20f2 ("docs: dma: correct dma_set_mask() sample code")

So remove return value check for dma_set_mask_and_coherent().

Reviewed-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: default avatarFrank Li <Frank.Li@nxp.com>
Link: https://lore.kernel.org/r/20250522-8qxp_camera-v5-5-d4be869fdb7e@nxp.com


Signed-off-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: default avatarHans Verkuil <hverkuil@xs4all.nl>
parent 60b8de2b

drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c

+1 −5
Original line number Diff line number Diff line
@@ -444,11 +444,7 @@ static int mxc_isi_probe(struct platform_device *pdev) 
	}



	dma_size = isi->pdata->has_36bit_dma ? 36 : 32;

	ret = dma_set_mask_and_coherent(dev, DMA_BIT_MASK(dma_size));

	if (ret) {

		dev_err(dev, "failed to set DMA mask\n");

		return ret;

	}

	dma_set_mask_and_coherent(dev, DMA_BIT_MASK(dma_size));



	pm_runtime_enable(dev);