Commit 73c46d9a authored by Henry Martin's avatar Henry Martin Committed by Stephen Boyd
Browse files

clk: bcm: rpi: Add NULL check in raspberrypi_clk_register() 



devm_kasprintf() returns NULL when memory allocation fails. Currently,
raspberrypi_clk_register() does not check for this case, which results
in a NULL pointer dereference.

Add NULL check after devm_kasprintf() to prevent this issue.

Fixes: 93d2725a ("clk: bcm: rpi: Discover the firmware clocks")
Signed-off-by: default avatarHenry Martin <bsdhenrymartin@gmail.com>
Reviewed-by: default avatarDave Stevenson <dave.stevenson@raspberrypi.com>
Link: https://lore.kernel.org/r/20250402020513.42628-1-bsdhenrymartin@gmail.com


Reviewed-by: default avatarStefan Wahren <wahrenst@gmx.net>
Signed-off-by: default avatarStephen Boyd <sboyd@kernel.org>
parent d6fbdae4

drivers/clk/bcm/clk-raspberrypi.c

+2 −0
Original line number Diff line number Diff line
@@ -286,6 +286,8 @@ static struct clk_hw *raspberrypi_clk_register(struct raspberrypi_clk *rpi, 
	init.name = devm_kasprintf(rpi->dev, GFP_KERNEL,

				   "fw-clk-%s",

				   rpi_firmware_clk_names[id]);

	if (!init.name)

		return ERR_PTR(-ENOMEM);

	init.ops = &raspberrypi_firmware_clk_ops;

	init.flags = CLK_GET_RATE_NOCACHE;