Commit 74139a64 authored by Miaoqian Lin's avatar Miaoqian Lin Committed by Kevin Hilman
Browse files

ARM: OMAP2+: pm33xx-core: ix device node reference leaks in amx3_idle_init 



Add missing of_node_put() calls to release
device node references obtained via of_parse_phandle().

Fixes: 06ee7a95 ("ARM: OMAP2+: pm33xx-core: Add cpuidle_ops for am335x/am437x")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarMiaoqian Lin <linmq006@gmail.com>
Link: https://lore.kernel.org/r/20250902075943.2408832-1-linmq006@gmail.com


Signed-off-by: default avatarKevin Hilman <khilman@baylibre.com>
parent 045e81d8

arch/arm/mach-omap2/pm33xx-core.c

+5 −1
Original line number Diff line number Diff line
@@ -388,12 +388,15 @@ static int __init amx3_idle_init(struct device_node *cpu_node, int cpu) 
		if (!state_node)

			break;



		if (!of_device_is_available(state_node))

		if (!of_device_is_available(state_node)) {

			of_node_put(state_node);

			continue;

		}



		if (i == CPUIDLE_STATE_MAX) {

			pr_warn("%s: cpuidle states reached max possible\n",

				__func__);

			of_node_put(state_node);

			break;

		}
@@ -403,6 +406,7 @@ static int __init amx3_idle_init(struct device_node *cpu_node, int cpu) 
			states[state_count].wfi_flags |= WFI_FLAG_WAKE_M3 |

							 WFI_FLAG_FLUSH_CACHE;



		of_node_put(state_node);

		state_count++;

	}