Commit 7433d022 authored by Oleksij Rempel's avatar Oleksij Rempel Committed by Jakub Kicinski
Browse files

net: usb: lan78xx: Use action-specific label in lan78xx_mac_reset 



Rename the generic `done` label to the action-specific `exit_unlock`
label in `lan78xx_mac_reset`. This improves clarity by indicating the
specific cleanup action (mutex unlock) and aligns with best practices
for error handling and cleanup labels.

Signed-off-by: default avatarOleksij Rempel <o.rempel@pengutronix.de>
Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
Reviewed-by: default avatarMateusz Polchlopek <mateusz.polchlopek@intel.com>
Link: https://patch.msgid.link/20241216120941.1690908-4-o.rempel@pengutronix.de


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 18bdefe6

drivers/net/usb/lan78xx.c

+6 −6
Original line number Diff line number Diff line
@@ -1604,16 +1604,16 @@ static int lan78xx_mac_reset(struct lan78xx_net *dev) 
	 */

	ret = lan78xx_mdiobus_wait_not_busy(dev);

	if (ret < 0)

		goto done;

		goto exit_unlock;



	ret = lan78xx_read_reg(dev, MAC_CR, &val);

	if (ret < 0)

		goto done;

		goto exit_unlock;



	val |= MAC_CR_RST_;

	ret = lan78xx_write_reg(dev, MAC_CR, val);

	if (ret < 0)

		goto done;

		goto exit_unlock;



	/* Wait for the reset to complete before allowing any further

	 * MAC register accesses otherwise the MAC may lock up.
@@ -1621,16 +1621,16 @@ static int lan78xx_mac_reset(struct lan78xx_net *dev) 
	do {

		ret = lan78xx_read_reg(dev, MAC_CR, &val);

		if (ret < 0)

			goto done;

			goto exit_unlock;



		if (!(val & MAC_CR_RST_)) {

			ret = 0;

			goto done;

			goto exit_unlock;

		}

	} while (!time_after(jiffies, start_time + HZ));



	ret = -ETIMEDOUT;

done:

exit_unlock:

	mutex_unlock(&dev->phy_mutex);



	return ret;