Commit 743677a8 authored by Maximilian Pezzullo's avatar Maximilian Pezzullo Committed by Jiri Kosina
Browse files

HID: amd_sfh: don't log error when device discovery fails with -EOPNOTSUPP 



When sensor discovery fails on systems without AMD SFH sensors, the
code already emits a warning via dev_warn() in amd_sfh_hid_client_init().
The subsequent dev_err() in sfh_init_work() for the same -EOPNOTSUPP
return value is redundant and causes unnecessary alarm.

Suppress the dev_err() for -EOPNOTSUPP to avoid confusing users who
have no AMD SFH sensors.

Fixes: 2105e8e0 ("HID: amd_sfh: Improve boot time when SFH is available")
Reported-by: default avatarCasey Croy <ccroy@bugzilla.kernel.org>
Closes: https://bugzilla.kernel.org/show_bug.cgi?id=221099


Signed-off-by: default avatarMaximilian Pezzullo <maximilianpezzullo@gmail.com>
Acked-by: default avatarBasavaraj Natikar <Basavaraj.Natikar@amd.com>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.com>
parent 53274394

drivers/hid/amd-sfh-hid/amd_sfh_pcie.c

+2 −1
Original line number Diff line number Diff line
@@ -413,6 +413,7 @@ static void sfh_init_work(struct work_struct *work) 
	rc = amd_sfh_hid_client_init(mp2);

	if (rc) {

		amd_sfh_clear_intr(mp2);

		if (rc != -EOPNOTSUPP)

			dev_err(&pdev->dev, "amd_sfh_hid_client_init failed err %d\n", rc);

		return;

	}