Commit 74371767 authored by Baokun Li's avatar Baokun Li Committed by Theodore Ts'o
Browse files

jbd2: remove jbd2_journal_unfile_buffer() 



Since the function jbd2_journal_unfile_buffer() is no longer called
anywhere after commit e5a120ae ("jbd2: remove journal_head from
descriptor buffers"), so let's remove it.

Signed-off-by: default avatarBaokun Li <libaokun1@huawei.com>
Reviewed-by: default avatarZhang Yi <yi.zhang@huawei.com>
Reviewed-by: default avatarJan Kara <jack@suse.cz>
Link: https://patch.msgid.link/20250306063240.157884-1-libaokun@huaweicloud.com


Signed-off-by: default avatarTheodore Ts'o <tytso@mit.edu>
parent 1b419c88

fs/jbd2/transaction.c

+0 −15
Original line number Diff line number Diff line
@@ -2075,21 +2075,6 @@ static void __jbd2_journal_unfile_buffer(struct journal_head *jh) 
	jh->b_transaction = NULL;

}



void jbd2_journal_unfile_buffer(journal_t *journal, struct journal_head *jh)

{

	struct buffer_head *bh = jh2bh(jh);



	/* Get reference so that buffer cannot be freed before we unlock it */

	get_bh(bh);

	spin_lock(&jh->b_state_lock);

	spin_lock(&journal->j_list_lock);

	__jbd2_journal_unfile_buffer(jh);

	spin_unlock(&journal->j_list_lock);

	spin_unlock(&jh->b_state_lock);

	jbd2_journal_put_journal_head(jh);

	__brelse(bh);

}



/**

 * jbd2_journal_try_to_free_buffers() - try to free page buffers.

 * @journal: journal for operation

include/linux/jbd2.h

+0 −1
Original line number Diff line number Diff line
@@ -1396,7 +1396,6 @@ JBD2_FEATURE_INCOMPAT_FUNCS(fast_commit, FAST_COMMIT) 
 */



/* Filing buffers */

extern void jbd2_journal_unfile_buffer(journal_t *, struct journal_head *);

extern bool __jbd2_journal_refile_buffer(struct journal_head *);

extern void jbd2_journal_refile_buffer(journal_t *, struct journal_head *);

extern void __jbd2_journal_file_buffer(struct journal_head *, transaction_t *, int);